From 59ba22638a942478fb7607190801062d6367c9b2 Mon Sep 17 00:00:00 2001
From: Edward <62042559+BeEdward@users.noreply.github.com>
Date: Thu, 6 Jul 2023 20:50:57 +0800
Subject: [PATCH] Apply suggestions from code review

Remove `hashtag` but use the first element of `hastags` instead for facebook hashtag parameter.

Co-authored-by: Nikita Karamov <me@kytta.dev>
---
 src/shareon.js | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/shareon.js b/src/shareon.js
index e514870..d9c3f83 100644
--- a/src/shareon.js
+++ b/src/shareon.js
@@ -17,7 +17,7 @@ import "./shareon.css";
  * }) => string}}
  */
 const urlBuilderMap = {
-  facebook: (d) => `https://www.facebook.com/sharer/sharer.php?u=${d.url}${d.hashtag? `&hashtag=#${d.hashtag}` : ''}`,
+  facebook: (d) => `https://www.facebook.com/sharer/sharer.php?u=${d.url}${d.hashtags? `&hashtag=#${d.hashtags.split(',')[0]}` : ''}`,
   linkedin: (d) => `https://www.linkedin.com/sharing/share-offsite/?url=${d.url}`,
   mastodon: (d) => `https://toot.kytta.dev/?text=${d.title}%0D%0A${d.url}${d.text ? `%0D%0A%0D%0A${d.text}` : ''}${d.via ? `%0D%0A%0D%0A${d.via}` : ''}`,
   messenger: (d) => `https://www.facebook.com/dialog/send?app_id=${d.fbAppId}&link=${d.url}&redirect_uri=${d.url}`,
@@ -85,11 +85,8 @@ const init = () => {
               via: encodeURIComponent(
                 child.dataset.via || container.dataset.via || ""
               ),
-              hashtag: encodeURIComponent(
-                child.dataset.hashtag || container.dataset.hashtag || ""
-              ),
               hashtags: encodeURIComponent(
-                child.dataset.hashtags?.replaceAll(', ', ',') || container.dataset.hashtags?.replaceAll(', ', ',') || ""
+                child.dataset.hashtags || container.dataset.hashtags || ""
               ),
               fbAppId: encodeURIComponent(
                 child.dataset.fbAppId || container.dataset.fbAppId || ""