From 9da80abfa52d2bc4c1c810e6294b794aae67a82e Mon Sep 17 00:00:00 2001 From: Nikita Karamov Date: Mon, 28 Sep 2020 13:33:36 +0200 Subject: [PATCH 1/2] Add FB App ID to possible data-attributes --- src/networks.js | 3 ++- src/shareon.js | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/networks.js b/src/networks.js index 1d65ca7..fd22895 100644 --- a/src/networks.js +++ b/src/networks.js @@ -5,6 +5,7 @@ * media?: string, * text?: string, * via?: string, + * fbAppId?: string, * }} PublicationData */ @@ -46,7 +47,7 @@ const NETWORKS = { messenger: { color: '#0099FF', icon: 'data:image/svg+xml,%3Csvg fill="%23fff" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"%3E%3Cpath d="M0 11.64C0 4.95 5.24 0 12 0s12 4.95 12 11.64-5.24 11.64-12 11.64c-1.21 0-2.38-.16-3.47-.46a.96.96 0 00-.64.05L5.5 23.92a.96.96 0 01-1.35-.85l-.07-2.14a.97.97 0 00-.32-.68A11.39 11.39 0 010 11.64zm8.32-2.19l-3.52 5.6c-.35.53.32 1.14.82.75l3.79-2.87c.26-.2.6-.2.87 0l2.8 2.1c.84.63 2.04.4 2.6-.48l3.52-5.6c.35-.53-.32-1.13-.82-.75l-3.79 2.87c-.25.2-.6.2-.86 0l-2.8-2.1a1.8 1.8 0 00-2.61.48z"/%3E%3C/svg%3E', - url: (d) => `https://www.facebook.com/dialog/send?app_id=3619024578167617&link=${d.url}&redirect_uri=${d.url}`, + url: (d) => `https://www.facebook.com/dialog/send?app_id=${d.fbAppId}&link=${d.url}&redirect_uri=${d.url}`, }, odnoklassniki: { color: '#EE8208', diff --git a/src/shareon.js b/src/shareon.js index 35b0864..3bf160e 100644 --- a/src/shareon.js +++ b/src/shareon.js @@ -49,6 +49,11 @@ const initializeShareon = () => { || container.dataset.via || '', ), + fbAppId: encodeURIComponent( + child.dataset.fbAppId + || container.dataset.fbAppId + || '', + ), }; const url = urlBuilderMap[cls](preset); From 35f497d3c1a9dc3fb052a9f6e1b83cd84a56f63a Mon Sep 17 00:00:00 2001 From: Nikita Karamov Date: Mon, 28 Sep 2020 13:48:10 +0200 Subject: [PATCH 2/2] Update the docs accordingly --- README.md | 8 +++++--- docs/index.html | 16 +++++++++------- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 4e53ee4..94d69d1 100644 --- a/README.md +++ b/README.md @@ -88,7 +88,8 @@ classes match the names of social networks: - + + @@ -117,6 +118,7 @@ on the whole container or on the specific buttons: Apart from the URL and title, some networks support extra parameters: +- you **have to** add `data-fb-app-id` to the FB Messenger button to make sharing even possible - add `data-media` to an Odnoklassniki, Pinterest, or VK button to customize the pinned picture - add `data-text` to a WhatsApp, Mastodon, Telegram or Viber button to add custom message text - add `data-via` to a Twitter or Mastodon button to mention a user @@ -126,12 +128,12 @@ Here are all the custom parameters in their glory: ```html
- + Pin - Send + Send
``` diff --git a/docs/index.html b/docs/index.html index a632262..f2f789c 100644 --- a/docs/index.html +++ b/docs/index.html @@ -69,7 +69,7 @@ - + @@ -188,7 +188,8 @@ shareon(); <a class="facebook"></a> <a class="linkedin"></a> <a class="mastodon"></a> - <a class="messenger"></a> + <!-- FB App ID is required for the Messenger button to function --> + <a class="messenger" data-fb-app-id="0123456789012345"></a> <a class="odnoklassniki"></a> <a class="pinterest"></a> <a class="pocket"></a> @@ -203,7 +204,7 @@ shareon(); - + @@ -243,6 +244,7 @@ shareon();